Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trade to asset not selecting account with highest balance #8371

Open
2 tasks done
MBMaria opened this issue Dec 15, 2024 · 5 comments
Open
2 tasks done

Trade to asset not selecting account with highest balance #8371

MBMaria opened this issue Dec 15, 2024 · 5 comments
Labels
needs product Requires product input before bounty

Comments

@MBMaria
Copy link

MBMaria commented Dec 15, 2024

Overview

When entering the asset to trade to, it doesn't always select the account with the highest balance

References and additional details

https://jam.dev/c/73c3cdeb-6529-484f-ad80-c76f65c765b9

Acceptance Criteria

Should select account with highest balance

Need By Date

No response

Screenshots/Mockups

No response

Ownership

  • If my bounty needs engineering or needs product I have added the respective labels on the right
  • As the sponsor of this bounty I will review the changes in a preview environment (ops/product) or review the PR (engineering)

Estimated effort

No response

Sponsor / Stakeholder

No response

Bounty Hunters

  • Join our discord
  • Include an expected timeline for you to complete work in the work plan when you apply for this bounty!
  • Please refer to this link for some basic info
  • Please do not start work on this issue until you are approved in Gitcoin.
@MBMaria MBMaria added bug Something isn't working needs engineering Requires engineering input before bounty labels Dec 15, 2024
@MBMaria
Copy link
Author

MBMaria commented Dec 16, 2024

Noticing this with send modal as well - doesnt have account with highest balance selected to send funds from
image

@0xean 0xean added needs product Requires product input before bounty and removed needs engineering Requires engineering input before bounty bug Something isn't working labels Dec 16, 2024
@0xApotheosis
Copy link
Member

0xApotheosis commented Dec 16, 2024

I suspect this is only an issue with UTXOs with respect to selecting the correct derivation path/type.

@0xean
Copy link
Contributor

0xean commented Dec 16, 2024

@twblack88 do you want to let us know expected behavior he and we can refine, may no actually be a bug since we don't necessarily want to send to legacy just because a small dust amount is there.

@twblack88
Copy link
Contributor

twblack88 commented Dec 18, 2024

I think it should just pick the largest balance. Should we create a threshold for dust?

@twblack88
Copy link
Contributor

bump.

does showing largest balance solve this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs product Requires product input before bounty
Projects
Status: Backlog
Development

No branches or pull requests

4 participants