Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lp nice to have ( fast follow) #6410

Closed
6 of 7 tasks
twblack88 opened this issue Mar 12, 2024 · 2 comments
Closed
6 of 7 tasks

Lp nice to have ( fast follow) #6410

twblack88 opened this issue Mar 12, 2024 · 2 comments
Assignees

Comments

@twblack88
Copy link
Contributor

twblack88 commented Mar 12, 2024

Overview

Tagging all the fast follow features that aren't launch blockers

References and additional details

For fees in summary modal let's just add the BPS so they are set up for success:
Trade Fee: $3,940.22 (10 bps)
FOX Discount: $200 (2 bps)
Total Trade Fee: $3,740.22 (8 bps)

For fees in simulator quoted from 6325 (im not sure why i copied but here we are):

We want to abstract fees to be feature specific. i know this is a PITA. Mainly because LP below $2k and trade below $1k right now. But will change with votes in future.

In general we should stop using the word "always" like "trades under 1k are always free."

If a discount is not applicable we should strikethrough the FOX power discount, or grey it out with an on.hover that says: below fee threshold for {feature}. This way it still reflects the 100% discount code but makes it clear in the UX that it doesn't matter.

Acceptance Criteria

Fixes go in
Test discounts math and it's sane
We can cross check math against spec in Github or somewhere ( will ask @purelycrickets about docs)

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

@twblack88
Copy link
Contributor Author

twblack88 commented Mar 13, 2024

  • Add wiki page for fee params and when the PR went in so DFC can start to use github. Gonna make this a DFC tracking thing and refer to a forum post that gets uploaded. All engineering/product will have to do is comment with the PR.

@twblack88 twblack88 moved this from Backlog to Up next in ShapeShift Dashboard Mar 13, 2024
@twblack88 twblack88 moved this from Up next to In progress in ShapeShift Dashboard Mar 13, 2024
@gomesalexandre
Copy link
Contributor

Closing as the bps stuff is unrelated to this issue as discussed with @twblack88 yesterday - see #6325 for the actual fee modal rework issue

@github-project-automation github-project-automation bot moved this from In progress to Done in ShapeShift Dashboard Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants