Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledger lending UX #5900

Closed
gomesalexandre opened this issue Dec 19, 2023 · 0 comments · Fixed by #5911
Closed

Ledger lending UX #5900

gomesalexandre opened this issue Dec 19, 2023 · 0 comments · Fixed by #5911
Assignees

Comments

@gomesalexandre
Copy link
Contributor

Overview

Lending is currently working for Ledger if you're ops or engineering - as a user, knowing you would have to connect/open the relevant app is not necessarily straightforward, so we need some UX in place to:

  1. alert you about chains you do not have connected, when trying to borrow an asset for it, or repay with it
  2. inform you about the need to open each app

References and additional details

N/A

Acceptance Criteria

  • Chains users do not have connected have clear warnings when trying to borrow / repay with, and we do not fire quotes for it. THOR's API currently guards against that, but relying on that is potentially dangerous

Proposed UI for that: either filter out unsupported chains, or have clear warnings in place and block quotes from being fired

  • There is an obvious info div telling users to open the relevant app on their device before signing time

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant