Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display all tx links in the trade UI #5888

Closed
woodenfurniture opened this issue Dec 18, 2023 · 0 comments · Fixed by #6026
Closed

Display all tx links in the trade UI #5888

woodenfurniture opened this issue Dec 18, 2023 · 0 comments · Fixed by #6026
Assignees

Comments

@woodenfurniture
Copy link
Member

woodenfurniture commented Dec 18, 2023

Overview

We currently only show 1 tx link while a trade is executing - the outbound tx link if it exists, and the inbound tx otherwise. For users this can be confusing because the txs that appear in the history dont align with the tx links they are given during trade execution.

To minimise confusion, we should simply render all tx links without and "tricky dicky" logic.

References and additional details

Relates to
#3446

Acceptance Criteria

All available tx links are rendered in the trade UI with no additional logic.

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

@woodenfurniture woodenfurniture self-assigned this Dec 18, 2023
@woodenfurniture woodenfurniture moved this from To schedule to Up next in ShapeShift Dashboard Jan 16, 2024
@woodenfurniture woodenfurniture moved this from Up next to In progress in ShapeShift Dashboard Jan 17, 2024
@woodenfurniture woodenfurniture moved this from In progress to In review in ShapeShift Dashboard Jan 17, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in ShapeShift Dashboard Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant