Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap max for non native assets #5828

Closed
0xean opened this issue Dec 11, 2023 · 2 comments · Fixed by #5961
Closed

swap max for non native assets #5828

0xean opened this issue Dec 11, 2023 · 2 comments · Fixed by #5961
Assignees

Comments

@0xean
Copy link
Contributor

0xean commented Dec 11, 2023

Background

Previously the team chose to remove Send Max functionality from the swapper due to complexities with gas, etc.
While this complexity still exists for native assets, for non native assets (IE ERC20) this shouldn't be a problem to allow a user to select to swap their entire balance.

AC

  • Create functionality to allow send max for non native assets (all erc20's)
    • Max component should be available somewhere to be added to the swapper
  • no change to functionality when a native asset is selected as the input to the swapper.
@0xean 0xean converted this from a draft issue Dec 11, 2023
@0xean 0xean changed the title send most / max swap most / max Dec 11, 2023
@0xean 0xean changed the title swap most / max swap max for non native assets Dec 11, 2023
@0xean 0xean moved this from To schedule to Up next in ShapeShift Dashboard Dec 11, 2023
@0xean
Copy link
Contributor Author

0xean commented Dec 20, 2023

holding for potential outside contributor to pick up, please don't pick this ticket up until we know if they would like to work on it.

@herbig
Copy link

herbig commented Dec 21, 2023

holding for potential outside contributor to pick up, please don't pick this ticket up until we know if they would like to work on it.

Hey @0xean you can assign me, I'm going to take a look at this today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants