Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Balance check for fees broken for multi-hop trades #5814

Closed
woodenfurniture opened this issue Dec 8, 2023 · 2 comments · Fixed by #6151
Closed

Balance check for fees broken for multi-hop trades #5814

woodenfurniture opened this issue Dec 8, 2023 · 2 comments · Fixed by #6151
Assignees
@woodenfurniture
Labels
bug Something isn't working
Milestone
multi-hop swaps

Comments

@woodenfurniture
Copy link
Member

Overview

Its currently possible to execute the first hop of 2 hop trade where there is insufficient balance to cover fees, resulting in trades failing on the second hop due to insufficient balance.

References and additional details

Error from optimism daemon:
image

Indeed, our balance is too low to cover the fees:
image

Acceptance Criteria

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response
@woodenfurniture woodenfurniture added this to the multi-hop swaps milestone Dec 8, 2023
@woodenfurniture woodenfurniture self-assigned this Dec 8, 2023
@woodenfurniture
Copy link
Member Author

Appears to be isolated to optimism due to gas estimation

@woodenfurniture woodenfurniture moved this from To schedule to Up next in ShapeShift Dashboard Jan 17, 2024
@woodenfurniture
Copy link
Member Author

need to wait for Kevin to get back before tackling this

@woodenfurniture woodenfurniture moved this from Up next to In progress in ShapeShift Dashboard Feb 1, 2024
@woodenfurniture woodenfurniture added the bug Something isn't working label Feb 1, 2024
@woodenfurniture woodenfurniture moved this from In progress to Blocked in ShapeShift Dashboard Feb 4, 2024
@woodenfurniture woodenfurniture moved this from Blocked to In progress in ShapeShift Dashboard Feb 4, 2024
@woodenfurniture woodenfurniture mentioned this issue Feb 7, 2024
Merged
3 tasks
@github-project-automation github-project-automation bot moved this from In progress to Done in ShapeShift Dashboard Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@woodenfurniture woodenfurniture

Labels
bug Something isn't working
Projects
ShapeShift Dashboard
Status: Done
Milestone
multi-hop swaps
Development

Successfully merging a pull request may close this issue.

fix: ensure optimism network fees are included in eip-1559 transactions shapeshift/web
1 participant
@woodenfurniture