Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle quotes that dont support custom slippage #5779

Closed
woodenfurniture opened this issue Dec 5, 2023 · 0 comments · Fixed by #5908
Closed

Handle quotes that dont support custom slippage #5779

woodenfurniture opened this issue Dec 5, 2023 · 0 comments · Fixed by #5908
Assignees

Comments

@woodenfurniture
Copy link
Member

woodenfurniture commented Dec 5, 2023

Overview

Some types of swappers (thorchain streaming swaps, cowswap) dont support the ability to specify the slippage when getting a quote, and we need a way to propagate this to users.

Implement a UI change that shows users what quotes are affected, using the attached mockup.

References and additional details

  • Also show another alert above the preview button IF that quote is selected.
  • Each quote will need to show the slippage, regardless of whether custom slippage was specified (for consistency and utility)
  • If the slippage is different than than the custom value, we show this warning state for the slippage
  • If custom slippage was not specified, dont show any warnings

Acceptance Criteria

  • Slippage dispayed on all quotes
  • Quotes ignoring the custom slippage (thorchain streaming swaps, cowswap) show warning icon with tolltip
  • Alert appears above the preview button when a quote ignoring custom slippage is selected

Need By Date

No response

Screenshots/Mockups

image

Estimated effort

No response

@woodenfurniture woodenfurniture self-assigned this Dec 5, 2023
@woodenfurniture woodenfurniture moved this from To schedule to Up next in ShapeShift Dashboard Dec 7, 2023
@woodenfurniture woodenfurniture moved this from Up next to In progress in ShapeShift Dashboard Dec 11, 2023
@woodenfurniture woodenfurniture moved this from In progress to Up next in ShapeShift Dashboard Dec 13, 2023
@woodenfurniture woodenfurniture moved this from Up next to In progress in ShapeShift Dashboard Dec 17, 2023
@woodenfurniture woodenfurniture moved this from In progress to Up next in ShapeShift Dashboard Dec 18, 2023
@woodenfurniture woodenfurniture moved this from Up next to In progress in ShapeShift Dashboard Dec 19, 2023
@github-project-automation github-project-automation bot moved this from In progress to Done in ShapeShift Dashboard Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant