Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge tradeQuoteSlice and swappersSlice #5742

Closed
woodenfurniture opened this issue Dec 1, 2023 · 0 comments · Fixed by #6035
Closed

Merge tradeQuoteSlice and swappersSlice #5742

woodenfurniture opened this issue Dec 1, 2023 · 0 comments · Fixed by #6035
Assignees
@woodenfurniture
Milestone
multi-hop swaps

Comments

@woodenfurniture
Copy link
Member

Overview

Simplify the state management of our application by combining 'swappersSliceandtradeQuoteSliceinto a new slice calledtradeSlice`.

This task includes combining swappersApi with swapperApi into tradeApi.

References and additional details

Best to start by:

  1. rename swappersSlice to tradeSlice
  2. rename swappersApi located at src/state/apis/swappers/index.ts to tradeApi located at src/state/apis/trade/index.ts
  3. move everything from tradeQuoteSlice into tradeSlice
  4. move everything from swapperApi into tradeApi

Acceptance Criteria

  1. 'swappersSliceandtradeQuoteSlicecombine into a new slice calledtradeSlice`.
  2. swappersApi with swapperApi combined into a new api called tradeApi.

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response
@woodenfurniture woodenfurniture added this to the multi-hop swaps milestone Dec 1, 2023
@woodenfurniture woodenfurniture self-assigned this Dec 1, 2023
@0xean 0xean moved this from To schedule to Up next in ShapeShift Dashboard Dec 4, 2023
@woodenfurniture woodenfurniture moved this from Up next to In progress in ShapeShift Dashboard Jan 17, 2024
@woodenfurniture woodenfurniture mentioned this issue Jan 17, 2024
Merged
3 tasks
@woodenfurniture woodenfurniture moved this from In progress to In review in ShapeShift Dashboard Jan 17, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in ShapeShift Dashboard Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@woodenfurniture woodenfurniture

Labels
None yet
Projects
ShapeShift Dashboard
Status: Done
Milestone
multi-hop swaps
Development

Successfully merging a pull request may close this issue.

chore: clean up of trade related slices and selectors shapeshift/web
1 participant
@woodenfurniture