Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility for blind users #5474

Closed
fcnjd opened this issue Oct 17, 2023 · 5 comments
Closed

Improve accessibility for blind users #5474

fcnjd opened this issue Oct 17, 2023 · 5 comments

Comments

@fcnjd
Copy link

fcnjd commented Oct 17, 2023

Overview

Since I am blind, I'm using a screenreader. Therefore, I'd like to suggest some accessibility improvements.

References and additional details

For replication, it might help to either turn on a screenreader, or use accessibility testing tools like Lighthouse.
Things I came across:

  • The radiobuttons to adjust what the chart shows are unlabelled
  • The checkbox at the total value of the wallet is unlabelled as well
  • The buttons on the dashboard (overview, wallet, rewards etc.) should be marked with aria-current attribute (and of course corresponding value) when the page is loaded
  • Currently, the lang attribute in the top-level HTML tag is always en. This should better dynamically change together with the current language, as like this a screenreader would read out the text with an English language, no matter which language is displayed

Acceptance Criteria

  • All HTML elements have labels
  • lang attribute dynamically changes to the preferred language
  • Tools for automatic testing (like Lighthouse) show 100%, since those tools should generally find nothing

Need By Date

No response

Screenshots/Mockups

No response

Estimated effort

No response

@purelycrickets
Copy link

@twblack88 this issue was created by a user some time ago, any chance we could get some accessibility friendly improvements prioritized around the above issues brought up?

@purelycrickets purelycrickets added needs product Requires product input before bounty bug Something isn't working labels Apr 22, 2024
@twblack88
Copy link
Contributor

pass for labels is a good callout and something that is doable. we'll spike into the HTML translation workflow.

@0xean 0xean removed the bug Something isn't working label Apr 22, 2024
@firebomb1
Copy link
Contributor

The above PR I've authored should address this part of the issue:

  • lang attribute dynamically changes to the preferred language

Thanks for bringing it to my attention!

@fcnjd
Copy link
Author

fcnjd commented Apr 23, 2024

Thank you very much for prioritizing the improvements - and already starting with it. I'm very glad to see progress going on here!

@twblack88 twblack88 added needs grooming and removed needs product Requires product input before bounty labels Jul 16, 2024
@0xean
Copy link
Contributor

0xean commented Jan 6, 2025

closing as not currently a priority

@0xean 0xean closed this as completed Jan 6, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in ShapeShift Dashboard Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

5 participants