-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compute shader indirect dispatch on Vulkan? #5844
Comments
@comradez this hasn't been implemented due to resource constraints. We are also moving to Slang-RHI as a replacement for slang-gfx. Can you try Slang-RHI repo instead and file an issue there for any gaps? |
Hi @comradez , I've also encounter this issue recently. So I try to implement vk::ComputeCommandEncoder::dispatchComputeIndirect in a fork (https://github.com/AdamYuan/slang/tree/falcor-8.0-better-vk) and it turns out to be a perfect solution. If you want to use the fork in Falcor (v8.0), simply replace <remote name="github-slang" type="https" packageLocation="github.com/shader-slang/slang/releases/download/v${version}/slang-${version}-${platform}.zip"/>
<dependency name="slang" linkPath="external/packman/slang">
<package name="slang" version="2024.1.34" remotes="github-slang" platforms="windows-x86_64 linux-x86_64"/>
</dependency> with <remote name="github-slang" type="https" packageLocation="github.com/AdamYuan/slang/releases/download/v${version}/slang-${version}-${platform}.zip"/>
<dependency name="slang" linkPath="external/packman/slang">
<package name="slang" version="2024.1.34-better-vk" remotes="github-slang" platforms="windows-x86_64 linux-x86_64"/>
</dependency> in |
The
dispatchComputeIndirect
for Vulkan compute encoder has always been unimplemented.I am using Falcor on Linux and trying some indirect dispatched compute shaders. As the
dispatchIndirect
call from Falcor goes throughslang-gfx
to the backend, I guess the only way to make it work is to implementvk::ComputeCommandEncoder::dispatchComputeIndirect
.Given that there is an implementation for D3D12, is any reason why this remains unimplemented, and are there possibilities to implement it? Very thanks!
The text was updated successfully, but these errors were encountered: