Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension unable to properly highlight terms after small edits to code #16

Open
pinecone69 opened this issue Oct 31, 2024 · 8 comments
Open
Assignees
Labels
bug Something isn't working goal:quality & productivity
Milestone

Comments

@pinecone69
Copy link

Tested in visual studio version 17.11.5

In example:

load a Slang file in visual studio with the following code:

int add2(int a, int b) {
    return a + b;
}

int add1(int a, int b) {
    return a + b;
}

void test() {
    int x = 4;
    int y = 2;
    int a = add1(x, y);
}

Now cut out the test function with Ctrl+X, paste it back in any location which actually changes the layout of the code from its previous layout. The colors become all messed up for some terms. Edit a Slang file for a while and syntax highlighting becomes very jumbled.

image

@csyonghe
Copy link
Contributor

csyonghe commented Nov 4, 2024

I followed your steps in visual studio, but I am not able to reproduce this behavior. What extension version are you on?

@pinecone69
Copy link
Author

pinecone69 commented Nov 4, 2024

I'm using extension version 1.1.8. I tried reinstalling.
Here is a video demonstration so you can see exactly what's happening on my screen:

example.mp4

@bmillsNV bmillsNV added this to the Q4 2024 milestone Nov 7, 2024
@bmillsNV bmillsNV added the bug Something isn't working label Nov 7, 2024
@bmillsNV bmillsNV assigned bmillsNV and jkwak-work and unassigned bmillsNV Nov 7, 2024
@bmillsNV
Copy link

bmillsNV commented Nov 7, 2024

Thanks for the clear repro video! @jkwak-work can you take a look next sprint?

@jkwak-work
Copy link

Yes, i will work on this next week.

@jkwak-work
Copy link

Yes, i will work on this next week.

For this sprint, I need to work on more higher priority tasks.
I will come back to this task on the next sprint.

@expipiplus1
Copy link

I wasn't able to reproduce this in vim either

https://asciinema.org/a/igy9fLeGyl1PxQ4u1vcdkECJs

Do you have anything else in your config which might cause things to differ from a vanilla setup?

@pinecone69
Copy link
Author

I wasn't able to reproduce this in vim either

https://asciinema.org/a/igy9fLeGyl1PxQ4u1vcdkECJs

Do you have anything else in your config which might cause things to differ from a vanilla setup?

No I don't think so

@csyonghe
Copy link
Contributor

I think this may be an issue specific to the Visual studio extension and not to the core language server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working goal:quality & productivity
Projects
None yet
Development

No branches or pull requests

5 participants