Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search in comments as well #45

Open
ezzra opened this issue Jan 8, 2019 · 5 comments
Open

search in comments as well #45

ezzra opened this issue Jan 8, 2019 · 5 comments

Comments

@ezzra
Copy link

ezzra commented Jan 8, 2019

the search function does not find words within comments, that could be helpful when implemented

@shacker
Copy link
Owner

shacker commented Jan 9, 2019

Not a bad idea. With larger databases with millions of comments, this could make search expensive (slow). We might want to make it a settings option for that reason. Also, it means searching two different models rather than one, so it's a more complex proposition, but I can see the use case. I'm going to let this one simmer for a bit, unless someone contributes code for it.

@bittner
Copy link
Contributor

bittner commented Jan 9, 2019

You may want to consider relying on Postgres capabilities. @pauloxnet had a few talks about this in the past (see related blog post).

@shacker
Copy link
Owner

shacker commented Mar 25, 2019

Based on the dust-up that occurred in #52, it's clear we have MySQL users, and we can't use anything postgres-specific unless the project makes a decision only to support Postgres. Part of me would love to do that, but I think the decision to go postres-only is up to individual projects and shouldn't be enforced by 3rd-party apps like this one. As long as Django supports MySQL, django-todo should support it too.

Still, this should not be too difficult to handle with traditional methods.

@dalinxz
Copy link

dalinxz commented Jan 24, 2020

Based on the dust-up that occurred in #52, it's clear we have MySQL users, and we can't use anything postgres-specific unless the project makes a decision only to support Postgres. Part of me would love to do that, but I think the decision to go postres-only is up to individual projects and shouldn't be enforced by 3rd-party apps like this one. As long as Django supports MySQL, django-todo should support it too.

Still, this should not be too difficult to handle with traditional methods.

My app is running Postgresql and it worked without a flaw, I did have to comment out the fieldsets in my CustomUser admin.py file prior to running the migration, otherwise I was getting a duplicate field in fieldset error. After commenting it out, it migrated perfectly, then I was able to uncomment the lines I commented and get back to business.

@dalinxz
Copy link

dalinxz commented Feb 1, 2020

Based on the dust-up that occurred in #52, it's clear we have MySQL users, and we can't use anything postgres-specific unless the project makes a decision only to support Postgres. Part of me would love to do that, but I think the decision to go postres-only is up to individual projects and shouldn't be enforced by 3rd-party apps like this one. As long as Django supports MySQL, django-todo should support it too.
Still, this should not be too difficult to handle with traditional methods.

My app is running Postgresql and it worked without a flaw, I did have to comment out the fieldsets in my CustomUser admin.py file prior to running the migration, otherwise I was getting a duplicate field in fieldset error. After commenting it out, it migrated perfectly, then I was able to uncomment the lines I commented and get back to business.

I was having this same issue on constantly having to uncomment the lines in the CustomUser admin.py file, I was able to address it by removing the two fieldsets that were already included on the built-in or allauth model, in my case it was username and email, removing those from the additional fieldsets removed Django from constantly piping about duplicate fieldsets. hope it helps..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants