Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build leads to shared library and standalone #127

Open
dvzrv opened this issue Feb 19, 2024 · 3 comments
Open

Build leads to shared library and standalone #127

dvzrv opened this issue Feb 19, 2024 · 3 comments

Comments

@dvzrv
Copy link

dvzrv commented Feb 19, 2024

Hi! 👋

When building 1.2.3 for Arch Linux I noticed, that the build and install targets lead to the shared library and the standalones to be built and installed.

I get the following files after picking out the plugin related files:

sfizz-ui-1.2.3-1-x86_64.pkg.tar.zst
-rw-r--r-- root/root      6819 2024-02-19 15:41 .BUILDINFO
-rw-r--r-- root/root      1058 2024-02-19 15:41 .MTREE
-rw-r--r-- root/root       937 2024-02-19 15:41 .PKGINFO
drwxr-xr-x root/root         0 2024-02-19 15:41 usr/
drwxr-xr-x root/root         0 2024-02-19 15:41 usr/bin/
-rwxr-xr-x root/root   1248888 2024-02-19 15:41 usr/bin/sfizz_jack
-rwxr-xr-x root/root   1437632 2024-02-19 15:41 usr/bin/sfizz_render
drwxr-xr-x root/root         0 2024-02-19 15:41 usr/include/
-rw-r--r-- root/root     41247 2024-02-19 15:41 usr/include/sfizz.h
-rw-r--r-- root/root     37450 2024-02-19 15:41 usr/include/sfizz.hpp
-rw-r--r-- root/root      3157 2024-02-19 15:41 usr/include/sfizz_message.h
drwxr-xr-x root/root         0 2024-02-19 15:41 usr/lib/
lrwxrwxrwx root/root         0 2024-02-19 15:41 usr/lib/libsfizz.so -> libsfizz.so.1
lrwxrwxrwx root/root         0 2024-02-19 15:41 usr/lib/libsfizz.so.1 -> libsfizz.so.1.2.3
-rwxr-xr-x root/root   1469208 2024-02-19 15:41 usr/lib/libsfizz.so.1.2.3
drwxr-xr-x root/root         0 2024-02-19 15:41 usr/lib/pkgconfig/
-rw-r--r-- root/root       255 2024-02-19 15:41 usr/lib/pkgconfig/sfizz.pc
drwxr-xr-x root/root         0 2024-02-19 15:41 usr/share/
drwxr-xr-x root/root         0 2024-02-19 15:41 usr/share/man/
drwxr-xr-x root/root         0 2024-02-19 15:41 usr/share/man/man1/
-rw-r--r-- root/root       585 2024-02-19 15:41 usr/share/man/man1/sfizz_jack.1.gz
-rw-r--r-- root/root       622 2024-02-19 15:41 usr/share/man/man1/sfizz_render.1.gz

I can of course remove those manually, but they should neither be built nor installed in this project.

Looking at what the created plugins link against, it appears those link against a static version of libsfizz.so.
Is this intended? Can this be changed?

@dvzrv
Copy link
Author

dvzrv commented Feb 19, 2024

FWIW, I am able to disable build of the standalones with -D SFIZZ_JACK=OFF and -D SFIZZ_RENDER=OFF.
But the shared library is still being built and installed.

@redtide
Copy link
Member

redtide commented Feb 19, 2024

when I made the repo split, I haven't taken into account also separated builds of the UI and library, just code separation, so I guess it's basically the same as the previous situation, including the static library.

Looking at what the created plugins link against, it appears those link against a static version of libsfizz.so.
Is this intended? Can this be changed?

I think we had some talk about it and both agree that needs to be changed in the Linux context, I see you are making 2 separated PKGBUILDs so I guess I should add some SFIZZ_USE_SYSTEM_SFIZZ 😄 to avoid it to build at all. Wasn't -D SFIZZ_SHARED=OFF of any help? (see CI build file)

@redtide
Copy link
Member

redtide commented Feb 22, 2024

Making plugins depending on the shared library is not that simple as I thought so for the time being:

  • this patch/commit updates to the latest VSTGUI, it should permit to build also against latest vst3sdk (VST3SDK: update to 3.7.10_build_14 #129)
  • I retried to build using -D SFIZZ_SHARED=OFF and the resulting install have only plugins. Will see later if I can disable it and clients by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants