Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output relevant signals during a severe fault scenario #44

Open
rafguevara14 opened this issue May 9, 2023 · 4 comments
Open

Output relevant signals during a severe fault scenario #44

rafguevara14 opened this issue May 9, 2023 · 4 comments
Assignees
Labels

Comments

@rafguevara14
Copy link
Collaborator

rafguevara14 commented May 9, 2023

I'm being vague because there may be other things to consider, but I think we have to notify the SDC in this event.

  1. Define what a fault scenario is.
  2. Are there any other cases where we would shut down the car?
  3. Figure out what signal we should send
  4. Implementation

Make a comprehensive list of what triggers the VCU to send a fault

@rafguevara14
Copy link
Collaborator Author

rafguevara14 commented Jul 12, 2024

For testing, as discussed with @juliannesoriano20 , check that when any of the shutdown events are triggered, the logs or a voltage is seen on the pin.

If too hard to test with the pin, just check logs

@juliannesoriano20
Copy link

Should VCU_FLT be kept high until the car is reset? I think it is good to keep VCU_FLT high whenever we have a fault, that way SDB is sure to act upon the signal. Then, only turn low once the car is reset and then we can set VCU_FLT low

@rafguevara14
Copy link
Collaborator Author

rafguevara14 commented Jul 12, 2024

Should VCU_FLT be kept high until the car is reset? I think it is good to keep VCU_FLT high whenever we have a fault, that way SDB is sure to act upon the signal. Then, only turn low once the car is reset and then we can set VCU_FLT low

I guess it depends on how the shutdown board is designed. Doublecheck if the shutdown board latches the signal based on this schematic.

image

Another issue is that we need to check if the reset signal is sent to the VCU.

@rafguevara14
Copy link
Collaborator Author

So for now, you can assume we have the reset signal available for us and do what you suggested (turn vcu fault low on a reset). Make a comment in the code about this assumption (eg TODO: Clarify if we have reset signal)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To do
Development

No branches or pull requests

2 participants