-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CloudEvents as standard event schema #65
Comments
I also find If need be I could do PRs (to every CQRS repo) adding a feature flag to enable with cqrs-es = "0.x"
postgres-es = "0.x" with cqrs-es = {version = "0.x", features = ["ulid"]}
postgres-es = {version = "0.x", features = ["ulid"]} |
@aurelien-clu I think that's a great idea and good first step towards getting best practice event format stored in the DB! PR encouraged :) |
I am unclear on the contribution guidelines so I will wait for the cqrs team to approve before I start 😉 |
Support for different serialization formats has been a topic since the beginning of this project, primarily to support protocol buffers for improved speed and lower storage requirements. I think the primary format should remain JSON since that is by far the most popular format but adding support for additional strategies should be trivial once that change is in place. I'm not familiar with CloudEvents so I'll need to take a closer look as to what that might entail. I've renamed this issue so we can track it here. Regarding the UUID library. This is not used internally by |
Hi Dave, Regarding UUIDs / ULIDs, no worries and understood. We're not talking about different serialisation formats here. CloudEvent is a CNCF standard event format specification. The issue is that the columns you've selected for the events table, do not match the CloudEvents spec. Given we're storing events here, I feel that the CloudEvents SDK should be used both internally inside the framework, and also that the table schema should reflect the standard event spec. The spec and the fields it entails can be found here. |
CloudEvents aims to be the universal standard for event schemas.
There is an SDK for Rust.
It would be fantastic if we could ensure the events published by the framework are stored in the database as a CloudEvent type with the data in the data field.
Additionally, I would advise using the ULID crate for the ID if you're open to this suggestion.
The text was updated successfully, but these errors were encountered: