Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress is corrupted when deploying a single function #173

Open
fabiob opened this issue Mar 3, 2019 · 1 comment
Open

Ingress is corrupted when deploying a single function #173

fabiob opened this issue Mar 3, 2019 · 1 comment

Comments

@fabiob
Copy link

fabiob commented Mar 3, 2019

When I perform a full deploy (using serverless deploy) of a stack containing multiple functions with http triggers, a single ingress is created, point to each one of them. That's really nice.

However, when I try to deploy a single function (using serverless deploy -f myFunc), the ingress is recreated and it starts pointing to that single function. All the other functions become inaccessible.

@andresmgot
Copy link
Contributor

Hi @fabiob, I can confirm that's an issue. The way it currently works is that we treat serverless deploy -f <func> as the whole deployment but with a single function. That has the side effect you mention.

See the code here:

https://github.com/serverless/serverless-kubeless/blob/master/deployFunction/kubelessDeployFunction.js#L40

The source of the issue here is that this plugin shouldn't create the Ingress objects itself, it should rely on the Kubeless backend to create them. What this plugin should create are "HTTP Trigger" objects the same way it creates Kafka or NATS triggers. The problem with that is that we would lose the aggregation of HTTP Triggers in a single Ingress object since that is not supported in Kubeless yet.

I don't have the resources to work on this right now so if anyone wants to give it a try I'll me happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants