Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more linting and other checks #133

Open
der-eismann opened this issue Feb 2, 2024 · 0 comments
Open

Add more linting and other checks #133

der-eismann opened this issue Feb 2, 2024 · 0 comments
Labels
area: tooling Tooling and Infra related

Comments

@der-eismann
Copy link
Contributor

To improve the quality of our package base, we need to introduce some opinionated checks and linters.
Ideas so far:

  • Comparing the binary manifest to the stone.yaml/manifest.jsonc to ensure package was actually built
  • At some point actually build changed packages in a PR and compare results
  • YAML formatting in general
  • Stuff inside the stone.yaml: Sorting of deps, trailing newlines etc

We implemented https://github.com/serpent-os/check-for-file-conflicts as a first step - pro: it's quick, relatively easy to read - con: it's TS/JS and we have nobody proficient in it. But it can do basically anything.

@der-eismann der-eismann added the area: tooling Tooling and Infra related label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tooling Tooling and Infra related
Projects
Development

No branches or pull requests

1 participant