Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(event): Update after simplification of event tables #1557

Merged

Conversation

kulla
Copy link
Member

@kulla kulla commented Jun 7, 2024

@kulla kulla linked an issue Jun 7, 2024 that may be closed by this pull request
@kulla
Copy link
Member Author

kulla commented Jun 7, 2024

@AndreasHuber @hugotiburtino I keep it as a draft PR until we decided that we want to add serlo/db-migrations#344 to the next release => However you can already review it

@hugotiburtino
Copy link
Member

hugotiburtino commented Jun 9, 2024

@AndreasHuber @hugotiburtino I keep it as a draft PR until we decided that we want to add serlo/db-migrations#344 to the next release

I think we should put it as soon as poosible in staging, in order to not have lots of PRs hanging around here. My only question is if we want to simplify even more the parameters (v.g. storing them as JSON in just one column).

@hugotiburtino hugotiburtino changed the base branch from staging to DNmHL-kulla-2024-06-09-12-05 June 14, 2024 15:57
@hugotiburtino hugotiburtino marked this pull request as ready for review June 14, 2024 15:57
@hugotiburtino hugotiburtino merged commit 632fd4b into DNmHL-kulla-2024-06-09-12-05 Jun 14, 2024
2 of 4 checks passed
@hugotiburtino hugotiburtino deleted the 1SWyC-kulla-2024-06-07-22-08 branch June 14, 2024 17:46
@hugotiburtino hugotiburtino mentioned this pull request Jun 14, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter objectId of events filters too much
2 participants