Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(SDKRLSD-1152): release 3.4.2 #165

Merged
merged 2 commits into from
Mar 6, 2024
Merged

chore(SDKRLSD-1152): release 3.4.2 #165

merged 2 commits into from
Mar 6, 2024

Conversation

bang9
Copy link
Collaborator

@bang9 bang9 commented Mar 5, 2024

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

SDKRLSD-1152

Description Of Changes

Add a brief description of the changes that you have involved in this PR

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@bang9 bang9 self-assigned this Mar 5, 2024
@bang9
Copy link
Collaborator Author

bang9 commented Mar 5, 2024

/bot create ticket

Copy link

github-actions bot commented Mar 5, 2024

Copy link

github-actions bot commented Mar 5, 2024

[Creating Ticket] In progress https://app.circleci.com/pipelines/github/sendbird/sdk-deployment/575

@sendbird-sdk-deployment
Copy link
Contributor

[Creating Ticket] 🔖 Done https://sendbird.atlassian.net/browse/SDKRLSD-1152

@bang9 bang9 changed the title chore: release 3.4.2 chore(SDKRLSD-1152): release 3.4.2 Mar 5, 2024
@bang9 bang9 requested review from liamcho and HoonBaek March 6, 2024 02:14
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.02%. Comparing base (f0d57f5) to head (e388063).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   13.02%   13.02%           
=======================================
  Files         334      334           
  Lines        7424     7424           
  Branches     2047     2047           
=======================================
  Hits          967      967           
  Misses       6386     6386           
  Partials       71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@liamcho liamcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@HoonBaek HoonBaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bang9 bang9 merged commit aabc6d6 into main Mar 6, 2024
6 checks passed
@bang9 bang9 deleted the release/3.4.2 branch March 6, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants