feat(CLNP-1132): zoomable image viewer #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bang9
changed the title
bang9
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
- Coverage 13.08% 13.04% -0.05%
==========================================
Files 331 334 +3
Lines 7388 7414 +26
Branches 2037 2045 +8
==========================================
Hits 967 967
- Misses 6351 6376 +25
- Partials 70 71 +1 ☔ View full report in Codecov by Sentry. |
AhyoungRyu
approved these changes
Jan 25, 2024
Comment on lines
+74
to
+75
| {mediaViewer} | ||
| {loading && <LoadingSpinner style={{ position: 'absolute' }} size={40} color={palette.primary300} />} |
There was a problem hiding this comment.
Suggested change
| {mediaViewer} | |
| {loading && <LoadingSpinner style={{ position: 'absolute' }} size={40} color={palette.primary300} />} | |
| {loading ? <LoadingSpinner style={{ position: 'absolute' }} size={40} color={palette.primary300} /> : mediaViewer} |
Should we display only one component depends on the loading status? Or it's just okay to keep both like the above?
There was a problem hiding this comment.
The loading state is controlled by the onLoadEnd event of the mediaViewer(ImageView or VideoView).
Therefore, the LoadingSpinner should take the form of covering the screen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External Contributions
This project is not yet set up to accept pull requests from external contributors.
If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.
For Internal Contributors
CLNP-1132
Description Of Changes
Types Of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply_