Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CLNP-2051): replaced useGroupChannelMessages #155

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Conversation

bang9
Copy link
Collaborator

@bang9 bang9 commented Jan 22, 2024

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

CLNP-2051

Description Of Changes

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@bang9 bang9 requested a review from HoonBaek January 22, 2024 03:35
@bang9 bang9 self-assigned this Jan 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (08c63bd) 13.09% compared to head (207ff0f) 13.08%.
Report is 2 commits behind head on main.

Files Patch % Lines
...groupChannel/component/GroupChannelMessageList.tsx 0.00% 5 Missing and 1 partial ⚠️
...ative/src/fragments/createGroupChannelFragment.tsx 0.00% 5 Missing ⚠️
...hannelMessages/useGroupChannelMessagesWithQuery.ts 0.00% 1 Missing ⚠️
...onents/ReactionAddons/BottomSheetReactionAddon.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
- Coverage   13.09%   13.08%   -0.01%     
==========================================
  Files         331      331              
  Lines        7387     7388       +1     
  Branches     2037     2037              
==========================================
  Hits          967      967              
- Misses       6350     6351       +1     
  Partials       70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@AhyoungRyu AhyoungRyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bang9 bang9 force-pushed the fix/mc-init-timing branch from 8d43deb to 207ff0f Compare January 22, 2024 04:11
@bang9 bang9 merged commit 7c99c96 into main Jan 22, 2024
6 checks passed
@bang9 bang9 deleted the fix/mc-init-timing branch January 22, 2024 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants