Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace padding with specific directions #153

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

bang9
Copy link
Collaborator

@bang9 bang9 commented Dec 8, 2023

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

[TICKET_ID]

Description Of Changes

  • Replace padding, paddingHorizontal and paddingVertical with paddingTop, paddingRight, paddingBottom and paddingLeft in the input style (due to bug in react-native).

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@bang9 bang9 self-assigned this Dec 8, 2023
@bang9 bang9 changed the title fix: replace padding horizontal and vertical fix: replace padding with specific directions Dec 8, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (08c63bd) 13.09% compared to head (24f49b4) 13.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   13.09%   13.09%           
=======================================
  Files         331      331           
  Lines        7387     7387           
  Branches     2037     2037           
=======================================
  Hits          967      967           
  Misses       6350     6350           
  Partials       70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bang9 bang9 merged commit 6e75382 into main Jan 22, 2024
6 checks passed
@bang9 bang9 deleted the fix/input-paddings branch January 22, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants