Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CLNP-1147): add reaction.onPressUserProfile to SendbirdUIKitContainer props #139

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

bang9
Copy link
Collaborator

@bang9 bang9 commented Oct 5, 2023

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

CLNP-1147

Description Of Changes

  • Add a reaction.onPressUserProfile to SendbirdUIKitContainer props
    onPress handler for below area

    screenshot

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@bang9 bang9 self-assigned this Oct 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (71a5b95) 14.43% compared to head (379bcce) 14.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
- Coverage   14.43%   14.43%   -0.01%     
==========================================
  Files         317      317              
  Lines        6496     6497       +1     
  Branches     1826     1827       +1     
==========================================
  Hits          938      938              
- Misses       5487     5488       +1     
  Partials       71       71              
Files Coverage Δ
...tive/src/components/ReactionBottomSheets/index.tsx 0.00% <ø> (ø)
...actionBottomSheets/ReactionUserListBottomSheet.tsx 0.00% <0.00%> (ø)
...t-native/src/containers/SendbirdUIKitContainer.tsx 0.00% <0.00%> (ø)
...es/uikit-react-native/src/contexts/ReactionCtx.tsx 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bang9 bang9 force-pushed the feat/reaction-handler branch from e9bd629 to 379bcce Compare October 5, 2023 08:38
@bang9 bang9 requested review from chrisallo and HoonBaek October 5, 2023 08:39
Copy link
Contributor

@chrisallo chrisallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bang9 bang9 merged commit 5af3fb7 into main Oct 12, 2023
@bang9 bang9 deleted the feat/reaction-handler branch October 12, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants