You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We use the simple svg to show the status of a document generation and finally the download icon for it. Because this changes fast, this component doesn't remove the first icon, as while setting the second, it was not yet loaded. This is what I can see while debugging:
generateInlineSVG is entered for the first filepath
generateInlineSVG is entered for the second filepath4
context.$el.appendChild(inlinedSVG) is run for the first filepath
context.$el.appendChild(inlinedSVG) is run for the second filepath
Because the previous icon is removed when the method is entered, if it was there, it's not in this case, as it wasn't added yet.
I know we can use the ready event, but that's just a workaround. This should be fixed, and probably improved by canceling the request when a new one is needed to be done.
The text was updated successfully, but these errors were encountered:
Trying for the workaround with the ready event, I see now that it's impossible. When it goes wrong, we don't get notified of an error either... I don't know the good way of doing this, but it has to be changed so we are notified of being done, even if it was an error, and possibly a way to throw the error up, or hook it up to custom error handling, messaging to the user with i18n.
We use the simple svg to show the status of a document generation and finally the download icon for it. Because this changes fast, this component doesn't remove the first icon, as while setting the second, it was not yet loaded. This is what I can see while debugging:
generateInlineSVG
is entered for the first filepathgenerateInlineSVG
is entered for the second filepath4context.$el.appendChild(inlinedSVG)
is run for the first filepathcontext.$el.appendChild(inlinedSVG)
is run for the second filepathBecause the previous icon is removed when the method is entered, if it was there, it's not in this case, as it wasn't added yet.
I know we can use the
ready
event, but that's just a workaround. This should be fixed, and probably improved by canceling the request when a new one is needed to be done.The text was updated successfully, but these errors were encountered: