Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circuit breaker url checked for every dynamo table being monitored? #236

Open
ricardclau opened this issue Mar 2, 2015 · 2 comments
Open

Comments

@ricardclau
Copy link
Contributor

Hi

I am seeing that the circuit breaker url is checked as many times as the # of tables being monitored.
Being it a "global" setting does it make sense to do it that way? Perhaps I am missing something?

Not that it is very high CPU consuming or anything but I was just curious about the motivation for doing it VS just asking once for every check interval

Info very much appreciated!

@sebdah
Copy link
Owner

sebdah commented Mar 3, 2015

Hey,

Yeah, well. I agree somehow. It's slightly unnecessary to do it once before each check (although the circuit breaker might be open between check 1 and 2 for example).

I would actually prefer to have it done before each table check, but configurable on a per table basis. It might be radically different checks for Table1 and Table2 for example.

@ricardclau
Copy link
Contributor Author

Yeah, I agree with your point as well

And you are totally right about the fact that there could be completely different checks between tables. Dynamo is a service tight to an AWS account, which may in fact mean several completely different applications

I will try to have a look later this week and perhaps contribute with a PR

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants