Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manufacturers referenced via first word #3

Open
xloem opened this issue Nov 7, 2022 · 1 comment
Open

manufacturers referenced via first word #3

xloem opened this issue Nov 7, 2022 · 1 comment

Comments

@xloem
Copy link

xloem commented Nov 7, 2022

Only first word of manufacturer is preserved:

self.manufacturer = self.get_first_prop(DEVICE_MANUFACTURER).split()[0].lower()

At https://developers.google.com/zero-touch/resources/manufacturer-names manufacturer values actually retain their entire string with spaces. If that's okay, it might mean adding quotes to shell scripts, not sure.

@SebaUbuntu
Copy link
Member

Yeah, the only reason I did that formatting is because I use the manufacturer value for device/$manufacturer/$codename device tree path
I should move this to aospdtgen/twrpdtgen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants