Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About yarock #1

Open
david-geiger opened this issue Oct 5, 2024 · 6 comments
Open

About yarock #1

david-geiger opened this issue Oct 5, 2024 · 6 comments

Comments

@david-geiger
Copy link

Hi,

Is this git repository the main official source code for yarock?

If yes have you planned to create a release tarball with current head code?

Regards,
David (Mageia Linux packager)

@sebaro
Copy link
Owner

sebaro commented Oct 5, 2024

Hi David,

The official/original source code is on Launchpad. There's no activity there in the last 5 years.
You can try contacting the original developer to see what's the status of the project.

My fork/repository contains the port to Qt6 and the QtMultimedia backend.
I can create a tarball release if needed.

@david-geiger
Copy link
Author

Yes It would be great to a tarball release :)

@sebaro
Copy link
Owner

sebaro commented Oct 7, 2024

Released 1.5.0.

@david-geiger
Copy link
Author

Thank you!

Is it possible to port it to new taglib v2?

/home/david/mgarepo/07_A_FAIRE/pango/trader/tdlib/GNOME/ldns/amarok/yarock/BUILD/Yarock-1.5.0/src/core/mediaitem/tag.cpp:716:28: error: 'AttachedPictureFrame' is not a member of 'TagLib::ID3v2'
716 | TagLib::ID3v2::AttachedPictureFrame *frame = dynamic_cast<TagLib::ID3v2::AttachedPictureFrame *>(*it);

@sebaro
Copy link
Owner

sebaro commented Oct 8, 2024

On Gentoo v2 is not available yet, I see they changed the headers, this header was included by asffile.h (asfpicture.h) now it's not.

This should be fixed if you include the header:
#include <taglib/attachedpictureframe.h>

@david-geiger
Copy link
Author

Yes perfect adding #include <taglib/attachedpictureframe.h> fixes build with taglib 2.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants