Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for roblox-ts modules #241

Open
Stefanuk12 opened this issue Dec 20, 2024 · 2 comments · May be fixed by #247
Open

support for roblox-ts modules #241

Stefanuk12 opened this issue Dec 20, 2024 · 2 comments · May be fixed by #247

Comments

@Stefanuk12
Copy link
Contributor

roblox-ts has their own way of linking files together through their runtime library. However, this can be an issue if you want to bundle all into one file. Ideally, a solution would parse the TS.import statement and TS.getModule statements inside of the import statement and resolve them to their actual paths for darklua to use.

@jeparlefrancais
Copy link
Contributor

Hello! Could Roblox-typescript generate different file paths? I'm wondering if I want to introduce logic into darklua that seems very specific. I think it'd be wise to avoid having an implicit dependency to Roblox-typescript.

I'm not familiar with Roblox-typescript, but it already does some code-generation so it could just generate valid Luau paths?

@Stefanuk12
Copy link
Contributor Author

It doesn't support the ability to do that yet, I did make a patch for it but it's pretty much useless since if you want to use other people's packages via npm, some of them upload the code with the TS.import already done. View an example here: https://www.npmjs.com/package/@flamework/core?activeTab=code

I understand this feature is specific to roblox-ts, but possibly a plugin system for darklua would be better.

@Stefanuk12 Stefanuk12 linked a pull request Dec 27, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants