Respect cap rights in capDL initialiser

[Ivan-Velickovic]

Not urgent, but I have noticed some code in the capDL initaliser code that does not respect the rights for a capability that is outlined in the given spec:

rust-sel4/crates/sel4-capdl-initializer/core/src/lib.rs

Line 429 in 484bb4b

cptr.mint(&orig_cptr, CapRights::all(), badge)?;

Just opening an issue to say we should look at all the points where cap rights are relevant and make sure they are respected.

[nspin]

You bring up a good point about that line.

I chose this behavior to match that of the C CapDL initializer:

https://github.com/seL4/capdl/blob/f7ef9ca4f9d3e1a8e86375deaf286a056698b9ce/capdl-loader-app/src/main.c#L1375-L1384

I agree that using logical_nfn_cap.rights() here would make for more sensible behavior. However, existing CapDL specs may depend on the C CapDL initializer's behavior here by not explicitly setting rights of notification caps that they bind to IRQ handlers.

Instead of modifying the Rust CapDL initializer immediately, perhaps it would be best to raise this as a larger issue for CapDL in general (that is, the C CapDL initializer, any other in-progress initializers, and CAmkES).

[Ivan-Velickovic]

Instead of modifying the Rust CapDL initializer immediately, perhaps it would be best to raise this as a larger issue for CapDL in general (that is, the C CapDL initializer, any other in-progress initializers, and CAmkES).

Good point, I'll bring it up at the development hangout tomorrow.