-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make "Test with:" support branches also #198
Comments
That is probably easy to add, and would be useful, yes. Does this add any new security considerations? So far, a PR must have been raised for the target to be included. Pretty much anyone can do that (apart from blocked users). So the new scope is someone pointing to some branch in a different org they control, but if they are a first-time contributor the tests have to be manually approved first anyway, so I think this is fine. |
Looking at https://github.com/seL4/ci-actions/pull/217/files, this could also support hashes. This feature might come for free if this is implemented with the standard git tools. Otherwise is should implement the same behavior, that matching a branch name take preference over matching a commit id. |
It'll not be entirely free, because constructing the ref for a PR is a bit special, but it could be done relatively easily. The relevant lines in scripts/fetch-extra-prs.sh are these: ci-actions/scripts/fetch-extra-prs.sh Lines 29 to 34 in 2416319
We'd need to do something similar as in fetch-branch.sh to distinguish pulling a sha from pulling a ref: ci-actions/scripts/fetch-branch.sh Lines 33 to 45 in 2416319
|
When working on forks and feature-branches, having "
Test with:
" support branches also besides just PRs would be nice. That avoids having to create PRs for every affected repo during the development cycle, but still allows using the github CI. The short syntax could be<org>/<repo>@<branch>
, the long syntax ishttps://github.com/<org>/<repo>/tree/<branch>
.The text was updated successfully, but these errors were encountered: