Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please fix wrong notice about old PHP construct #8

Open
ovr opened this issue Aug 15, 2015 · 0 comments
Open

Please fix wrong notice about old PHP construct #8

ovr opened this issue Aug 15, 2015 · 0 comments

Comments

@ovr
Copy link

ovr commented Aug 15, 2015

Here, you can explain why the found issue was invalid, and what result
you would have expected otherwise.

Please also check that this issue has not already been reported.

class Factory {
    public static function factory($id, array $parameters, Service $service)
}

Error

Using PHP4-style constructors that are named like the class is not recommend; better use the more explicit __construct method.

Please check !$method->isStatic() before

see https://scrutinizer-ci.com/g/SocialConnect/auth/inspections/e3b853ab-234b-430f-a64a-0aca979526b4/issues/files/src/Provider/Factory.php?status=existing&orderField=path&order=asc&issueId=23c195b1-1cf6-4d38-ad20-25eb77456e7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ovr