Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow graph drawn poorly with line not attached to node #3229

Open
VonnyJap opened this issue Oct 21, 2024 · 0 comments
Open

Workflow graph drawn poorly with line not attached to node #3229

VonnyJap opened this issue Oct 21, 2024 · 0 comments

Comments

@VonnyJap
Copy link
Member

What happened:

With the config below:

---
version: 4
shared:
    image: node:20
    annotations:
        screwdriver.cd/cpu: LOW
        screwdriver.cd/ram: LOW
    parameters:
        CUSTOM_VERSION: "v.0.0.1"
        fail: "fail"
annotations:
    screwdriver.cd/chainPR: true

jobs:
    meta-set:
        requires: [~pr, ~commit]
        steps:
            - meta-before-set: |
                set -x
                meta get img_version
            - set-meta: |
                set -x
                meta set img_version "$(meta get parameters.CUSTOM_VERSION.value)"
    meta-middleware:
        requires: [meta-set]
        steps:
            - decision: |
                set -x
                fail_value=$(meta get parameters.fail.value)
                if [ "$fail_value" = "fail" ]; then
                    exit 1
                else
                    echo "img_version: $(meta get img_version)"
                fi
    meta-final:
        requires: [meta-set, meta-middleware]
        steps:
            - success: |
                echo "success"
                echo "img_version: $(meta get img_version)"

The workflow graph rendered looks very confusing.

Screenshot 2024-10-20 at 11 10 01 PM

What you expected to happen:

the line between meta-middleware node to meta-final should be clearly shown that it is leaving from one node to another, right now it does not connect properly, node to node.

How to reproduce it:

Please use this sd config to reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant