Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's hard to configure multiple POST URLs per asset type #61

Open
rschamp opened this issue Dec 10, 2018 · 0 comments
Open

It's hard to configure multiple POST URLs per asset type #61

rschamp opened this issue Dec 10, 2018 · 0 comments

Comments

@rschamp
Copy link
Contributor

rschamp commented Dec 10, 2018

When remixing or creating a project as a copy, we use query strings to modify the URL, e.g. /?is_copy=1&title=My Project Title. Since we only rely on storage looking up the right handler based on the asset id, we don't have a way to dynamically set parameters for a particular store().

We need to do some thinking on the design of store since it now doesn't work ideally for either of the servers we're using it for. Our config for assets hack around the current design, which was created around project creation: https://github.com/LLK/scratch-gui/blob/develop/src/lib/storage.js#L24-L28, and we aren't using it at all for project creation anymore because of this URL issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants