Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break out cpu-specific and gpu-specific code from RenderWebGL.js file #679

Open
fsih opened this issue Aug 20, 2020 · 0 comments
Open

Break out cpu-specific and gpu-specific code from RenderWebGL.js file #679

fsih opened this issue Aug 20, 2020 · 0 comments

Comments

@fsih
Copy link
Contributor

fsih commented Aug 20, 2020

The renderer may use the CPU or GPU depending on the processing power of the machine it's running on. There is a bunch of code that does the same stuff for the CPU and GPU paths, e.g. implementation of touching color. Many bugs come from the fact that these 2 paths are out of sync

It's difficult to parse RenderWebGL.js and easily see which code is shared by both paths, which functions are CPU specific and which functions are GPU specific. Breaking out the specific code into their own files would more easily ensure that when you fix one you need to fix the other and which code is shared.

@fsih fsih added the tech debt label Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant