Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convex hulls should be calculated in texture space, not "native size" space #592

Open
adroitwhiz opened this issue May 4, 2020 · 0 comments · May be fixed by #724
Open

Convex hulls should be calculated in texture space, not "native size" space #592

adroitwhiz opened this issue May 4, 2020 · 0 comments · May be fixed by #724

Comments

@adroitwhiz
Copy link
Contributor

Expected Behavior

To ensure maximum accuracy, skins' convex hulls should be calculated in texture-space by going over each texel. This will also ensure fencing compatibility with Scratch 2.0.

Actual Behavior

Currently, convex hulls are generated at the "native size" of the skin. For bitmap skins, this is half their resolution, and that leads to certain inaccuracies when generating convex hulls for bitmap costumes.

Steps to Reproduce

Currently, there are enough existing issues with the way "silhouettes" work (convex hulls are generated from "silhouettes") that it's probably impossible to trace any specific issue back to this bug. Once #479 goes in, I can provide some concrete examples.

Operating System and Browser

All

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants