Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NumPy 1.18 is not properly supported #2784

Closed
agoose77 opened this issue Oct 30, 2023 · 3 comments · Fixed by #2783
Closed

NumPy 1.18 is not properly supported #2784

agoose77 opened this issue Oct 30, 2023 · 3 comments · Fixed by #2783
Labels
bug The problem described is something that must be fixed

Comments

@agoose77
Copy link
Collaborator

agoose77 commented Oct 30, 2023 •
edited
Loading

Version of Awkward Array

main

Description and code to reproduce

NumPy 1.18 is very old, so few people were actually testing this.

We were not aware of the problem until we introduced features that silently depended upon "NumPy>=1.24", which is much newer; downstream projects (coffea) tested against 1.18 < numpy < 1.24 and raised the alarm.
@agoose77 agoose77 added bug (unverified) The problem described would be a bug, but needs to be triaged bug The problem described is something that must be fixed and removed bug (unverified) The problem described would be a bug, but needs to be triaged labels Oct 30, 2023
@agoose77 agoose77 mentioned this issue Oct 30, 2023
Merged
@jpivarski
Copy link
Member

I'm wondering why this test didn't catch it. Here is an example of the last time it ran.

@agoose77
Copy link
Collaborator Author

See #2783!

@jpivarski
Copy link
Member

Yikes; okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The problem described is something that must be fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: fix oldest-supported-dependencies test workflow scikit-hep/awkward
2 participants
@agoose77 @jpivarski