Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images may be unversioned #102

Open
giorgiosironi opened this issue Jul 17, 2018 · 7 comments
Open

Images may be unversioned #102

giorgiosironi opened this issue Jul 17, 2018 · 7 comments

Comments

@giorgiosironi
Copy link

In case someone else run into this, for example mailcatcher only contains a latest tag which means automated builds using it may lead to a different results as that tag evolves and a new version is pushed. The list of versions contains tens of different versions that have all been overwritten on the same tag.

@OlivierCuyp
Copy link
Collaborator

The issue is that all the dockerfiles are stored under the same repository.
So there is no way to add tag for individual image through Docker Automatic Builds.
If we had tags they would apply to all the images.
The only way to me would be to create a repository per project.
Maybe @schickling have an other idea on this...

@laszlof
Copy link

laszlof commented Jul 23, 2018

This bit us in the butt as well. You changed the beanstalkd dockerfile to use ENTRYPOINT rather than CMD. We were using the box with the Vagrant docker provider, and passing in a custom cmd option to add parameters (specifically the -z param).

Versioning would have fixed this. though I see your problem with having them all in one repo.

@OlivierCuyp
Copy link
Collaborator

Agreed that versions would have been very nice.
We try to avoid compatibility break as much as possible but changes have always hidden side effects.
Sorry about that.

@giorgiosironi
Copy link
Author

FWIW in https://github.com/elifesciences/elife-base-images we apply tags based on the commit sha, which is unreadable but at least guarantees to unambiguously identify every new image being pushed:
https://hub.docker.com/r/elifesciences/python/tags/

@giorgiosironi
Copy link
Author

Another option is to tag with a date like 20180731 or 2018073111900, which is slightly more understandable.

@OlivierCuyp
Copy link
Collaborator

@giorgiosironi thanks for your advice.
I believe you use Jenkins to build and push your images on DockerHub.
This gives you more control than us since we are using DockerHub Automated Build.
In our, case we can only tag on github release.
But as I said in a previous comment all our images would get the same tags even if they didn't change.

@tholu
Copy link

tholu commented Feb 3, 2020

@schickling Any plans to tag images with versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants