Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deb packages aren't getting their data gzipped anymore #189

Open
hrhino opened this issue May 15, 2018 · 11 comments
Open

deb packages aren't getting their data gzipped anymore #189

hrhino opened this issue May 15, 2018 · 11 comments
Assignees

Comments

@hrhino
Copy link

hrhino commented May 15, 2018

hhoughton:Downloads hhoughton$ for i in 3 4; do ar -t scala-2.13.0-M$i.deb; echo; done
debian-binary
control.tar.gz
data.tar.gz

debian-binary
control.tar.gz
data.tar

Probably caused by #180. Newer versions of sbt-native-packager pass -Znone to dpkg, because "packages are largely JARs, which are already compressed". However, the packaged scaladoc has nearly 500MB (uncompressed) of docs, which benefit greatly from compression.

I'll double-check that that's the problem, but it seems the most likely.

Thanks to @Glavo for noticing.

@hrhino hrhino self-assigned this May 15, 2018
@SethTisue
Copy link
Member

SethTisue commented May 15, 2018

ha, nice catch @Glavo

@dwijnand
Copy link
Member

Workaround with debianNativeBuildOptions in Debian -= "-Znone", perhaps?

@hrhino
Copy link
Author

hrhino commented May 15, 2018

Yeah, that's what I was going to do.

I think I'd call that the "fix" rather than a "workaround", though :P

@dwijnand
Copy link
Member

Why is the packaged scaladoc not compressed? As I understand it you have to opt-in to do that: https://docs.oracle.com/javase/tutorial/deployment/jar/build.html

@hrhino
Copy link
Author

hrhino commented May 15, 2018

so I did that (the -= "-Znone"), and show debian:packageBin::debianNativeBuildOptions tells me that that's not getting passed, but I'm still not getting anything built. I also can't find the older version of sbt-native-packager anywhere, so I'm a little stumped on how to try this out.

@hrhino
Copy link
Author

hrhino commented May 15, 2018

The scaladoc isn't packaged in a jar for debian; it's exploded into /usr/share/doc before making the .deb file.

@dwijnand
Copy link
Member

I also can't find the older version of sbt-native-packager anywhere, so I'm a little stumped on how to try this out.

I can see it in:
https://repo.scala-sbt.org/scalasbt/sbt-plugin-releases/com.typesafe.sbt/sbt-native-packager/scala_2.10/sbt_0.13/1.0.6/jars/

@dwijnand
Copy link
Member

The scaladoc isn't packaged in a jar for debian; it's exploded into /usr/share/doc before making the .deb file.

I see!

@hrhino
Copy link
Author

hrhino commented May 15, 2018

I can see it in:
repo.scala-sbt.org/scalasbt/sbt-plugin-releases/com.typesafe.sbt/sbt-native-packager/scala_2.10/sbt_0.13/1.0.6/jars

yep, it's there. Dunno why sbt isn't looking there by default, though... (it presumably resolved earlier without any extra resolvers.)

@dwijnand
Copy link
Member

That's where it should be resolving from, out the box. So not sure what's up, without digging into it more.

@retronym
Copy link
Member

I'm trying to upgrade scala-dist to the latest versions of SBT and plugins, could be a good time to revisit this.

#215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants