-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version conflicts for scala-parser-combinators #1461
Comments
Thanks for the comprehensive report 🤗 Indeed shading should be the way to go. I'm really surprised how many plugins rely on this lib 😅 You wouldn't have time by chance to provide a pull request 😁😘 |
got similar issue:
in my case caused by |
Problem is solved in master it seems since #1455 |
Sorry, I missed out on releasing this. |
After re-reading the history of this, I'm not sure if shading is necessary. @mkurz wrote a very comprehensive comment
which I interpret as "there's no way until, let's say sbt 2.x along with scala3, this dependency can ever be upgraded to the 2.x line". If this is correct, then shading would add no benefit, right? |
Shading could help by avoiding the resolution conflict, but is there a benefit updating that dependency ? |
@muuki88 This issue can be closed, since it is fixed with vv1.9.5+. |
Hello,
I'm getting this issue in sbt:
Here's my entire
plugins.sbt
file:With such dependencies, I think shading is a good solution.
The text was updated successfully, but these errors were encountered: