Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin with 'Root Admin (Full Admin Access)' permissions not able to delete bans #988

Open
DNA-styx opened this issue Sep 3, 2024 · 2 comments

Comments

@DNA-styx
Copy link

DNA-styx commented Sep 3, 2024

What are the steps to reproduce this issue?

  1. Log in with account that has 'Root Admin (Full Admin Access)' permissions
  2. Go to bans page
  3. Select one or more bans
  4. Click 'actions' drop down

What happens?

'Delete' option doesn't appear in drop down

What were you expecting to happen?

'Delete' option to appear in drop down

Any logs, error output, etc.?

Currently
image

After below fix
image

Looks to be fixed by changing line 812 of page.banslist.php

$theme->assign('can_delete', $userbank->HasAccess(ADMIN_OWNER) || HasAccess(ADMIN_DELETE_BAN));

Any other comments?

This issue appears to be in the comms block page as well.

What versions of software are you using?

Operating System:
SourceBans++ Version: 1.8.0 | Git: 1411
PHP Version:
MySQL Version:
Link to your project:
Link to a phpinfo() output:

@Rushaway
Copy link
Contributor

Could you verify your user permission ?
I was unable to repro this issue, also this issue can't occure on comms list, the tickbox feature is not implanted in it yet.

@DNA-styx
Copy link
Author

Thanks for checking. Yes, only applies to Bans page

My permissions
image
Set using
image
Bans page with variables echoed
image
Using this code
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants