Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Num2Words Arabic Number Representation Violates Grammatical Rules for 100 and Its Multiples #557

Open
bm-rana opened this issue Jan 26, 2024 · 1 comment

Comments

@bm-rana
Copy link

bm-rana commented Jan 26, 2024

Expected Behavior

the expected behaviour of the Num2Words is to generate accurate linguistic representations of numbers in the Arabic language (case of two "مثنى"), considering grammatical rules, especially in the context of 100 and its multiples.
In case of رفع, the library should convert the number ending with "ان" , and in the نصب case, it should convert the number ending with "ين"

Actual Behavior

The generated output is the conversion of the numbers ending in all cases of mothanna (case of two "مثنى") with "ان" in both the "رفع" case in the "نصب" case.

Steps to reproduce

  • step 1
    Introduce a new class attribute named "rafea" within the "init" method and set it to True to activate the رفع (rafea) condition.
  • step 2
    add an if condition to check the state of the "rafea" flag. If rafea flag is true, num2words functions normally and converts the 100 and its multiples ending with "ان".
    else, if rafea flag is is set to false, num2words converts 100 and its multiples ending with "ين" .
@mrodriguezg1991
Copy link
Contributor

Hello, sorry i don't speak the language, but all contributions are appreciated, if you have the time, a PR with the fix is welcome, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants