You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are several issues with the Korean ordinal conversion in the to_ordinal function.
The function throws an error when the input is 100 or 1000.
The function always appends '번째' to the ordinal, which may not always be desired. For example, when converting 100, the output should be '백', not '백 번째'.
The function does not consider different ways of expressing 1 in Korean. In Korean, 1 can be expressed as '첫 번째' or '한번' in ordinal form.
There are several issues with the Korean ordinal conversion in the
to_ordinal
function.Expected Behaviour
There are errors on 100, 1000
Actual Behaviour
Steps to reproduce
to_ordinal
function with 100 or 1000 as input without error.Suggested Test Code Snippet
In the case below, it is left to the developer's authority to attach '번, 번째, 째, 차'.
The text was updated successfully, but these errors were encountered: