Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Bugs and features (dev) #6

Closed
4 of 5 tasks
sauravhiremath opened this issue May 24, 2020 · 2 comments
Closed
4 of 5 tasks

Minor Bugs and features (dev) #6

sauravhiremath opened this issue May 24, 2020 · 2 comments
Assignees
@sauravhiremath
Labels
bug Something isn't working

Comments

@sauravhiremath
Copy link
Owner

sauravhiremath commented May 24, 2020 •
edited
Loading

  • Make password functionality optional
  • Router allow redirecting to the game screen after auth (Disallowed for good, reason explained below)
  • Show connected players and their ready Status
  • Add server status messages on the client screen.
    (Ex: tropen left the room)
  • Add authentication headers to sockets
@sauravhiremath sauravhiremath changed the title Minor Bugs Minor Bugs (dev) May 24, 2020
@sauravhiremath sauravhiremath self-assigned this May 24, 2020
@sauravhiremath sauravhiremath added the bug Something isn't working label May 24, 2020
@sauravhiremath
Copy link
Owner Author

Make password optional sorted in commit 5db7d1b

@sauravhiremath sauravhiremath changed the title Minor Bugs (dev) Minor Bugs and features (dev) May 24, 2020
@sauravhiremath
Copy link
Owner Author

✖️✖️✖️ Redirect to the game screen after auth is disallowed. ✖️✖️✖️

  • Prevents opening of unnecessary listeners before joining the page. (Can be exploited by just opening many links, hence is disallowed now)
  • Only one entry point through room join. Easier to handle edge cases

@sauravhiremath sauravhiremath pinned this issue May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sauravhiremath sauravhiremath

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sauravhiremath