Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dart 3 class modifiers to public classes #1978

Open
nex3 opened this issue May 26, 2023 · 1 comment
Open

Add Dart 3 class modifiers to public classes #1978

nex3 opened this issue May 26, 2023 · 1 comment
Labels
blocked Waiting on another issue to be fixed enhancement
Milestone

Comments

@nex3
Copy link
Contributor

nex3 commented May 26, 2023

Pretty much all the classes we expose publicly in the Dart API should have some form of class modifier, but adding this would be a breaking change, so we should wait until 2.0.0.

@nex3 nex3 added enhancement blocked Waiting on another issue to be fixed labels May 26, 2023
@nex3 nex3 added this to the 2.0.0 milestone May 26, 2023
@nex3
Copy link
Contributor Author

nex3 commented Jun 28, 2023

I think it's fine to convert classes that have the @sealed annotation to sealed or final, but we shouldn't do so for un-annotated classes and we can't safely mark classes as base or interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Waiting on another issue to be fixed enhancement
Projects
None yet
Development

No branches or pull requests

1 participant