Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arrow >= 1.0 #199

Closed
gavinhodge opened this issue Apr 21, 2021 · 4 comments
Closed

Support arrow >= 1.0 #199

gavinhodge opened this issue Apr 21, 2021 · 4 comments

Comments

@gavinhodge
Copy link

There are some breaking changes in the arrow 1.0 release. I noticed when using toyplot.locator.Timestamp, as the ticks() function will crash.

Toyplot doesn't pin the arrow dependency, so pip will install the latest version by default.

Notably, timestamp has been renamed to int_timestamp, and replaced by a function timestamp(). So the various tick generators need to either reference int_timestamp or call timestamp().

I'm not sure which is better for backwards compatibility.

@gavinhodge
Copy link
Author

Arrow v1.0 migration guide:
arrow-py/arrow#832

@tshead2
Copy link
Member

tshead2 commented Apr 21, 2021

@gavinhodge - many thanks for this, will work on a fix right away.

Cheers,
Tim

@jdtuck
Copy link

jdtuck commented Jan 1, 2022

@tshead2 Do we have a fix for this? since it is not pinned and arrow has gone to 1.2 makes it a pain to just install it.

@tshead2
Copy link
Member

tshead2 commented Jan 4, 2022

Fixed in e0cf9da.

@tshead2 tshead2 closed this as completed Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants