Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Children text nodes of ruby container spans must be pruned after style resolution #162

Open
palemieux opened this issue Aug 14, 2019 · 4 comments
Assignees

Comments

@palemieux
Copy link
Contributor

palemieux commented Aug 14, 2019

if (estack[0] instanceof Span) {

cleanRubyContainers(doc.body);

The computed value of tts:ruby cannot be determined until after style resolution, which happens during ISD creation.

@palemieux palemieux self-assigned this Aug 14, 2019
@palemieux
Copy link
Contributor Author

See w3c/ttml2#1140

@cfadamp
Copy link

cfadamp commented Jul 16, 2020

Hi,

is this ticket about the same problem that I just discovered?
See example ttml file, current IMSCJ1_1 render png, and proposed correct render png.
ruby_problem.zip

Let me know if I should open a new ticket.
Thanks,
Adam

@palemieux
Copy link
Contributor Author

palemieux commented Jul 16, 2020

@cfadamp I am not sure the rendering labeled wrong is incorrect: as far as I know, ruby text that is wider than the base does not typically overhang preceding/following Kanji -- see 3.2(4) at https://www.w3.org/TR/2020/WD-simple-ruby-20200609/

@cfadamp
Copy link

cfadamp commented Jul 16, 2020

@palemieux thank you, I will check this out.
Please ignore my comment, as it turned out it is not related to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants