data-attributes

[Anmo]

With the issue #5 (PR #6) we can use any attribute, including data-attribute:

  mount(Button, {
    attributes: {
      'data-this-is-a-data-attribute': true,
    },
  });

But to facilitate, we could have also a dataAttribute parameter:

  mount(Button, {
    dataAttributes: {
      thisIsADataAttribute: true,
    },
  });

To achieve this we could have a simple function like this:

function __pwUpdateDataAttributes(webComponent, dataAttributes = {}) {
  Object.assign(webComponent.dataset, dataAttributes)
}

[sand4rt]

Thank you for creating the issue! Could you tell a bit more about why this is useful for testing?

[Anmo]

sorry for the late reply

This is just a nice to have, like I said in the description, with the support for attributes on #6 we can use pass data attributes, but would be easy to use this way, because instead of writing the name of the data attribute with - and therefore the need for using a string, like this:

mount(Button, {
    attributes: {
      'data-attribute-name': true,
    },
  });

you would be able to pass a camel case name (and therefore, without being a string), like this:

mount(Button, {
  dataAttributes: {
    attributeName: true,
  },
});

[sand4rt]

This is just a nice to have

I don't see how the behaviour of the component is tested with dataAttributes. I'm hesitant to add this because i don't want to deviate from Playwright's API unless there is a good reason.

[sand4rt]

Closed due to inactivity, feel free to create a new ticket whenever needed