Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to SimpleJWT #24

Closed
samyachour opened this issue May 18, 2019 · 0 comments
Closed

Switch to SimpleJWT #24

samyachour opened this issue May 18, 2019 · 0 comments
Assignees
@samyachour
Labels
bug Something isn't working

Comments

@samyachour
Copy link
Owner

samyachour commented May 18, 2019 •
edited
Loading

The issue with Django-rest-framework-JWT is you cannot use an expired token to refresh. So I can't save a token to the keychain then on next app startup (within refresh delta e.g. 30 days) grab a new one after the first 401.

Not to mention Django-rest-framework-JWT hasn't been updated in 2 years!

It seems like poor design but luckily there is a different library Django-rest-framework-simpleJWT that implements separate access and refresh tokens.

Need to set this up in environment and django API settings.
@samyachour samyachour added the bug Something isn't working label May 18, 2019
@samyachour samyachour self-assigned this May 18, 2019
samyachour added a commit that referenced this issue May 18, 2019
@samyachour
issue #24 Updating documentation, tests, settings, and urls with Simp…
0d9ddd2 
…leJWT framework, removing all old JWT related code
@samyachour samyachour mentioned this issue May 18, 2019
Merged
samyachour added a commit that referenced this issue May 18, 2019
@samyachour
Merge pull request #25 from samyachour/issue24/bug/fixjwtrefresh
5476466 
issue #24 Switching to simpleJWT framework
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samyachour samyachour

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samyachour