Requires ZipFile.jl v0.2.7 (Doesn't work on Windows)

[davidanthoff]

Tests fail on Windows:

               _
   _       _ _(_)_     |  A fresh approach to technical computing
  (_)     | (_) (_)    |  Documentation: http://docs.julialang.org
   _ _   _| |_  __ _   |  Type "?help" for help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 0.4.6 (2016-06-19 17:16 UTC)
 _/ |\__'_|_|_|\__'_|  |  Official http://julialang.org/ release
|__/                   |  x86_64-w64-mingw32

julia> Pkg.test("InfoZIP")
INFO: Testing InfoZIP
ERROR: LoadError: test error in expression: dict == test_unzip(create_zip(dict))
MethodError: `convert` has no method matching convert(::Type{ZipFile.Writer}, ::Base.AbstractIOBuffer{Array{UInt8,1}}, ::Bool)
This may have arisen from a call to the constructor ZipFile.Writer(...),
since type constructors fall back to convert methods.
Closest candidates are:
  ZipFile.Writer(::IO)
  ZipFile.Writer(::IO, ::Array{ZipFile.WritableFile,1}, ::Union{Void,ZipFile.WritableFile}, ::Bool)
  call{T}(::Type{T}, ::Any)
  ...
 in setindex! at C:\Users\anthoff\.julia\v0.4\InfoZIP\src\zip_file.jl:118
 in anonymous at C:\Users\anthoff\.julia\v0.4\InfoZIP\src\zip_file.jl:194
 in with_close at C:\Users\anthoff\.julia\v0.4\InfoZIP\src\zip_file.jl:35
 in create_zip at C:\Users\anthoff\.julia\v0.4\InfoZIP\src\zip_file.jl:192
 in anonymous at C:\Users\anthoff\.julia\v0.4\InfoZIP\src\zip_file.jl:236
 in with_close at C:\Users\anthoff\.julia\v0.4\InfoZIP\src\zip_file.jl:35
 in create_zip at C:\Users\anthoff\.julia\v0.4\InfoZIP\src\zip_file.jl:235
 in anonymous at test.jl:90
 in do_test at test.jl:50
 in include at boot.jl:261
 in include_from_node1 at loading.jl:320
 in process_options at client.jl:280
 in _start at client.jl:378
 in setindex! at C:\Users\anthoff\.julia\v0.4\InfoZIP\src\zip_file.jl:118
 in anonymous at C:\Users\anthoff\.julia\v0.4\InfoZIP\src\zip_file.jl:194
 in with_close at C:\Users\anthoff\.julia\v0.4\InfoZIP\src\zip_file.jl:35
 in create_zip at C:\Users\anthoff\.julia\v0.4\InfoZIP\src\zip_file.jl:192
 in anonymous at C:\Users\anthoff\.julia\v0.4\InfoZIP\src\zip_file.jl:236
 in with_close at C:\Users\anthoff\.julia\v0.4\InfoZIP\src\zip_file.jl:35
 in create_zip at C:\Users\anthoff\.julia\v0.4\InfoZIP\src\zip_file.jl:235
 in anonymous at test.jl:90
 in do_test at test.jl:50
 in include at boot.jl:261
 in include_from_node1 at loading.jl:320
 in process_options at client.jl:280
 in _start at client.jl:378
while loading C:\Users\anthoff\.julia\v0.4\InfoZIP\test\runtests.jl, in expression starting on line 50
=============================================================[ ERROR: InfoZIP ]==============================================================

failed process: Process(`'C:\Users\anthoff\AppData\Local\julia-stable\bin\julia' --check-bounds=yes --code-coverage=none --color=yes 'C:\Users\anthoff\.julia\v0.4\InfoZIP\test\runtests.jl'`, ProcessExited(1)) [1]

=============================================================================================================================================
ERROR: InfoZIP had test errors
 in error at error.jl:21

julia>

#4 would probably catch these types of things.

[samoconnor]

Thanks for reporting this @davidanthoff.
On windows, InfoZip.jl falls back on using ZipFile.jl (instead of the unix unzip tool).
The problem seems to be that InfoZip.jl depends on an un-tagged change in InfoZip.jl : fhs/ZipFile.jl@5c6cf3d

When I force use ZipFile.jl on unix, I get the same error as you.

When I upgrade to the latest ZipFile.jl it works...

julia> Pkg.checkout("ZipFile")
INFO: Checking out ZipFile master...
INFO: Pulling ZipFile latest master...
INFO: No packages to install, update or remove

julia> Pkg.test("InfoZip")
INFO: Testing InfoZip
WARNING: InfoZIP falling back to ZipFile.jl backend!
INFO: InfoZip tests passed

[davidanthoff]

Thanks! I'll close for now.