Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closure compiler creates a map that points to a *.tmp file #103

Closed
nurv opened this issue Jun 7, 2015 · 4 comments
Closed

Closure compiler creates a map that points to a *.tmp file #103

nurv opened this issue Jun 7, 2015 · 4 comments
Assignees
Milestone

Comments

@nurv
Copy link

nurv commented Jun 7, 2015

The plugin currently has a concatenation step before sending the file into the magnification.

This behaviour is at odds with the Closure Compiler. The compiler expects to receive all the files separately, one to make sense of @Private annotations and also for the the .map file.

If you compile with the latest version of the plugin, the final .map file will point to a transient file called .tmp that does not exist on the final output.

For an example of the configuration you can see this file:

@i045053
Copy link

i045053 commented Jul 6, 2015

Is that what you are looking for? #98

@nurv
Copy link
Author

nurv commented Jul 6, 2015

@i045053 you've submited an Issue and not a Pull Request. You should submit a pull request if you wish for me to view the code.

@i045053
Copy link

i045053 commented Jul 6, 2015

Sorry, new to github, the pull request is here: #97

@samaxes samaxes added this to the 1.7.6 milestone Oct 26, 2016
@samaxes samaxes self-assigned this Oct 26, 2016
@samaxes
Copy link
Owner

samaxes commented Oct 26, 2016

I will come back to this issue on the next release.
Closing this issue as the issue is the same as #98.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants